alamb commented on code in PR #9617:
URL: https://github.com/apache/arrow-rs/pull/9617#discussion_r3003281571
##########
arrow-csv/src/writer.rs:
##########
@@ -1027,10 +1057,80 @@ sed do eiusmod
tempor,-556132.25,1,,2019-04-18T02:45:55.555,23:46:03,foo
let mut buffer: Vec<u8> = vec![];
file.read_to_end(&mut buffer).unwrap();
- assert_eq!(
- "c1,c2\n00:02,46:17\n00:02,\n",
- String::from_utf8(buffer).unwrap()
- );
+ let output = String::from_utf8(buffer).unwrap();
+ assert_eq!(output, "c1,c2\n00:02,46:17\n00:02,\n");
+ }
+
+ #[test]
+ fn test_write_csv_with_lf_terminator() {
Review Comment:
these tests are quite repetitive (they are like 20 lines long but the only
difference is 2 lines -- the terminaor and the expected output)
Can you please refactor them into a common harness so that it is easier for
(me, a human) to review them and ensure coverage is adequate?
Thank you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
