lidavidm commented on code in PR #4155:
URL: https://github.com/apache/arrow-adbc/pull/4155#discussion_r3007017128
##########
rust/driver_manager/src/search.rs:
##########
@@ -612,6 +613,13 @@ impl<'a> DriverLibrary<'a> {
})
}
+ fn platform_library_path(path: &Path) -> PathBuf {
+ let file_name = path
+ .file_name()
+ .expect("driver search paths must include a file name");
Review Comment:
I'd prefer we don't use `expect` even if it seems we shouldn't be able to
ever hit the error case
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
