alamb commented on code in PR #9629: URL: https://github.com/apache/arrow-rs/pull/9629#discussion_r3017924349
########## .github/workflows/miri.sh: ########## @@ -12,9 +12,8 @@ cargo miri setup cargo clean echo "Starting Arrow MIRI run..." -cargo miri test -p arrow-buffer -cargo miri test -p arrow-data --features ffi -cargo miri test -p arrow-schema --features ffi -cargo miri test -p arrow-ord -cargo miri test -p arrow-array -cargo miri test -p arrow-arith \ No newline at end of file +cargo miri nextest run \ Review Comment: TIL: https://nexte.st/docs/integrations/miri/ ########## .github/workflows/miri.yaml: ########## @@ -55,6 +55,8 @@ jobs: rustup toolchain install nightly --component miri rustup override set nightly cargo miri setup + - name: Set up nextest Review Comment: This action scares me security wise (as it runs some bash script) https://github.com/apache/arrow-rs/actions/runs/23751988211/job/69196496005?pr=9629 I think it would be better (if not ideal) to install nextest explicitly (`cargo install cargo-nextest --version 0.9.132`) rather than use this pre-built binary -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
