wgtmac commented on code in PR #49627:
URL: https://github.com/apache/arrow/pull/49627#discussion_r3019403820
##########
cpp/src/parquet/decoder.cc:
##########
@@ -1484,6 +1484,9 @@ class DeltaBitPackDecoder : public
TypedDecoderImpl<DType> {
}
std::vector<T> values(num_values);
int decoded_count = GetInternal(values.data(), num_values);
+ if (decoded_count < num_values) {
Review Comment:
Do we need to add ARROW_PREDICT_FALSE?
##########
cpp/src/parquet/decoder.cc:
##########
@@ -1484,6 +1484,9 @@ class DeltaBitPackDecoder : public
TypedDecoderImpl<DType> {
}
std::vector<T> values(num_values);
int decoded_count = GetInternal(values.data(), num_values);
+ if (decoded_count < num_values) {
+ ParquetException::EofException();
Review Comment:
nit: add a concrete error message?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
