returnString commented on issue #243: URL: https://github.com/apache/arrow-datafusion/issues/243#issuecomment-832678280
Having some issues with cross on Windows so can't repro, but do we _need_ the `to_usize` conversion for the failing `to_hex` function impl? From a cursory glance, looks like we're using `i64::MAX` as a test input, which doesn't fit into the ptr size on a 32-bit arch, but maybe there's a better way to handle the string formatting requirements here. Personally I can't think of many other 32-bit use cases so am totally fine with the "use x64" workaround, but if we _do_ want to support it we should probably get some CI coverage going! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
