lidavidm commented on a change in pull request #10060:
URL: https://github.com/apache/arrow/pull/10060#discussion_r626579413
##########
File path: cpp/src/arrow/dataset/file_parquet.cc
##########
@@ -385,6 +385,23 @@ Result<ScanTaskIterator> ParquetFileFormat::ScanFile(
return MakeVectorIterator(std::move(tasks));
}
+util::optional<Future<int64_t>> ParquetFileFormat::CountRows(
+ const std::shared_ptr<FileFragment>& file, Expression predicate,
+ std::shared_ptr<ScanOptions> options) {
+ auto parquet_file =
internal::checked_pointer_cast<ParquetFileFragment>(file);
+ if (FieldsInExpression(predicate).size() > 0) {
Review comment:
It works for some predicates - so now it's implemented. It'll naturally
get better as the expression machinery improves.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
