crepererum commented on code in PR #630:
URL:
https://github.com/apache/arrow-rs-object-store/pull/630#discussion_r3027499816
##########
Cargo.toml:
##########
@@ -51,45 +51,42 @@ form_urlencoded = { version = "1.2", optional = true }
http-body-util = { version = "0.1.2", optional = true }
httparse = { version = "1.8.0", default-features = false, features = ["std"],
optional = true }
hyper = { version = "1.2", default-features = false, optional = true }
-md-5 = { version = "0.11.0", default-features = false, optional = true }
+md-5 = { version = "0.10.6", default-features = false, optional = true }
quick-xml = { version = "0.39.0", features = ["serialize",
"overlapped-lists"], optional = true }
-rand = { version = "0.10", default-features = false, features = ["std",
"std_rng", "thread_rng"], optional = true }
+rand = { version = "0.9", default-features = false, features = ["std",
"std_rng", "thread_rng"], optional = true }
reqwest = { version = "0.12", default-features = false, features =
["rustls-tls-native-roots", "http2"], optional = true }
ring = { version = "0.17", default-features = false, features = ["std"],
optional = true }
rustls-pki-types = { version = "1.9", default-features = false, features =
["std"], optional = true }
serde = { version = "1.0", default-features = false, features = ["derive"],
optional = true }
serde_json = { version = "1.0", default-features = false, features = ["std"],
optional = true }
serde_urlencoded = { version = "0.7", optional = true }
+tokio = { version = "1.29.0", features = ["sync", "macros", "rt", "time",
"io-util"] }
-# Optional tokio feature
-tokio = { version = "1.29.0", features = ["sync", "macros", "rt", "time",
"io-util"], optional = true }
-tracing = { version = "0.1", optional = true }
+[target.'cfg(target_family="unix")'.dependencies]
+xattr = { version = "1", optional = true }
[target.'cfg(target_family="unix")'.dev-dependencies]
-nix = { version = "0.31.1", features = ["fs"] }
+nix = { version = "0.30.0", features = ["fs"] }
[target.'cfg(all(target_arch = "wasm32", target_os = "unknown"))'.dependencies]
web-time = { version = "1.1.0" }
wasm-bindgen-futures = "0.4.18"
-futures-channel = {version = "0.3", features = ["sink"]}
[features]
Review Comment:
Yes, but you still need to define the feature. An optional dependency
doesn't automatically define a feature, no?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
