jonkeane commented on PR #49655:
URL: https://github.com/apache/arrow/pull/49655#issuecomment-4183955981
That looks good. We'll need to add an exception to the regex (or find the
right targeted skipping env var, which I think is
`_R_CHECK_COMPILATION_FLAGS_`) for:
```
* checking compilation flags used ... NOTE
Compilation used the following non-portable flag(s):
‘-Wp,-D_FORTIFY_SOURCE=3’
```
~But, now that I'm looking, something is up with that runner, cause we don't
see that issue on CRAN:
https://www.r-project.org/nosvn/R.check/r-devel-linux-x86_64-fedora-clang/arrow-00check.html
which is odd. [The configuration on CRAN's
docs](https://www.stats.ox.ac.uk/pub/bdr/Rconfig/r-devel-linux-x86_64-fedora-clang)
looks similar to rhub (though rhub _is_ using ubuntu and not fedora here)~
We should actually add
`_R_CHECK_COMPILATION_FLAGS_KNOWN_="-Werror=implicit-function-declaration
-Wno-error=enum-constexpr-conversion -Wp,-D_FORTIFY_SOURCE=3
-Wno-missing-template-arg-list-after-template-kw"` to that one clang runner.
I'll work on an upstream for rhub.
And FTR, here are the incoming checks:
https://github.com/wch/r-source/blob/373f689c72f127d1f11f80b7ddb5058d4aca1e7a/src/library/tools/R/check.R#L6784-L6836
Which we have covered elsewhere, so I'm not too worried about those.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
