jonkeane commented on code in PR #49653:
URL: https://github.com/apache/arrow/pull/49653#discussion_r3033432766
##########
r/src/arrow_cpp11.h:
##########
@@ -388,13 +400,12 @@ SEXP to_r6(const std::shared_ptr<T>& ptr, const char*
r6_class_name) {
cpp11::external_pointer<std::shared_ptr<T>> xp(new std::shared_ptr<T>(ptr));
SEXP r6_class = Rf_install(r6_class_name);
-// R_existsVarInFrame doesn't exist before R 4.2, so we need to fall back to
-// Rf_findVarInFrame3 if it is not defined.
-#if R_VERSION >= R_Version(4, 2, 0)
+#if R_VERSION >= R_Version(4, 6, 0)
if (!R_existsVarInFrame(arrow::r::ns::arrow, r6_class)) {
cpp11::stop("No arrow R6 class named '%s'", r6_class_name);
}
#else
+ // Rf_findVarInFrame3 and R_UnboundValue are non-API as of R 4.6
Review Comment:
But this else was only <4.2.0 anyway no?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
