Dandandan commented on PR #9662: URL: https://github.com/apache/arrow-rs/pull/9662#issuecomment-4186958273
> I would have expected the compiler to optimize these copies away. > > Still might be a good idea, since it also simplifies the logic a bit. I don't quite like how the method is intentionally unsupported for some of the `FromBytes` implementations. What do you think of introducing a separate trait like `FromBitpacked` (similar to `FromPrimitive`, but also implemented for `bool`)? These methods are quite hot in DataFusion profiles, so I think they are likely not optimized away (I run some benchmarks and/or check). >I don't quite like how the method is intentionally unsupported for some of the FromBytes implementations. > What do you think of introducing a separate trait like FromBitpacked (similar to FromPrimitive, but also implemented for bool)? Agreed. I'll check! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
