jatorre commented on issue #867: URL: https://github.com/apache/arrow-nanoarrow/issues/867#issuecomment-4194331259
Thanks @paleolimbot! You were right — the issue is in `duckdb-nanoarrow`, specifically in `FunctionFinal()` which never emitted the EOS marker (unlike `ArrowStreamWriter::Finalize()` which already does it correctly for file output). I've opened a PR with a fix: https://github.com/paleolimbot/duckdb-nanoarrow/pull/49 The change is minimal: - When `FunctionFinal()` flushes remaining buffered data, it now returns `HAVE_MORE_OUTPUT` instead of `FINISHED` - On the next call it emits the 8-byte EOS marker as a final blob row - Updated the existing test to account for the extra row, and added a new test that concatenates all blobs into a single stream and reads it with `RecordBatchStreamReader` Happy to adjust anything — let me know what you think! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
