tilinna commented on issue #703:
URL: https://github.com/apache/arrow-go/issues/703#issuecomment-4194483376

   For me it would be enough to have it documented, so that I can work around 
it. Also, should fix Close() to not to always return nil. Something like this:
   
   file_writer.go:
   
   ```go
   // Close closes any open row group writer and writes the file footer. 
Subsequent
   // calls to close will have no effect.
   func (fw *Writer) Close() (err error) {
     if fw.open {
       ..
     }
     return nil
   }
   ```
   =>
   
   ```go
   // Close closes any open row group writer, writes the file footer, and 
closes the
   // underlying writer if it implements io.Closer. Subsequent calls to Close 
will
   // have no effect.
   func (fw *Writer) Close() (err error) {
     if fw.open {
       ..
     }
     return
   }
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to