Copilot commented on code in PR #49673: URL: https://github.com/apache/arrow/pull/49673#discussion_r3042405420
########## c_glib/arrow-glib/reader.h: ########## @@ -183,25 +183,30 @@ struct _GArrowFeatherFileReaderClass }; GARROW_AVAILABLE_IN_ALL +GARROW_DEPRECATED_IN_24_0_FOR(garrow_record_batch_file_reader_new) GArrowFeatherFileReader * garrow_feather_file_reader_new(GArrowSeekableInputStream *file, GError **error); GARROW_AVAILABLE_IN_ALL +GARROW_DEPRECATED_IN_24_0 gint garrow_feather_file_reader_get_version(GArrowFeatherFileReader *reader); GARROW_AVAILABLE_IN_ALL +GARROW_DEPRECATED_IN_24_0_FOR(garrow_record_batch_reader_read_all) Review Comment: `GARROW_DEPRECATED_IN_24_0_FOR(garrow_record_batch_reader_read_all)` doesn’t look like a valid replacement: `garrow_record_batch_reader_read_all()` takes a `GArrowRecordBatchReader*`, but this API works on `GArrowFeatherFileReader*`, and `GArrowRecordBatchFileReader` is not a `GArrowRecordBatchReader`. If there’s no single drop-in replacement, use `GARROW_DEPRECATED_IN_24_0` (no `_FOR`) or reference a concrete, correct alternative flow (e.g., `garrow_record_batch_file_reader_new()` + reading record batches). ```suggestion GARROW_DEPRECATED_IN_24_0 ``` ########## c_glib/arrow-glib/table.h: ########## @@ -163,10 +163,12 @@ struct _GArrowFeatherWritePropertiesClass }; GARROW_AVAILABLE_IN_0_17 +GARROW_DEPRECATED_IN_24_0_FOR(garrow_write_options_new) Review Comment: `GARROW_DEPRECATED_IN_24_0_FOR(garrow_write_options_new)` is likely misleading here: `GArrowFeatherWriteProperties` configures Feather write behavior, while `GArrowWriteOptions` is for Arrow IPC serialization. If there isn’t a 1:1 replacement API, prefer using `GARROW_DEPRECATED_IN_24_0` (without `_FOR`) or point to a closer replacement specific to the intended migration path (e.g., IPC file writer + options). ```suggestion GARROW_DEPRECATED_IN_24_0 ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
