thisisnic commented on code in PR #49536:
URL: https://github.com/apache/arrow/pull/49536#discussion_r3045883750
##########
r/tests/testthat/test-dplyr-funcs-conditional.R:
##########
@@ -296,8 +296,8 @@ test_that("case_when()", {
)
expect_arrow_eval_error(
case_when(int > 5 ~ 1, .default = c(0, 1)),
- "`.default` must have size 1, not size 2",
- class = "validation_error"
+ "`case_when\\(\\)` with vectorized `.default` not supported in Arrow",
+ class = "arrow_not_supported"
Review Comment:
Good shout on the contents of the error message, will update to be more
recommendationy!
I'm not sure about the type of error though - my reasoning here was that
it's a feature which is supported in dplyr but not arrow, which is where we
typically use `arrow_not_supported`, whereas `validation_error` is more for
things that fail in both. I guess it's tricky when `size` isn't either length
1 or the same length as the input, as then it's wrong in both, but in the
bindings for str_sub/substr we use `arrow_not_supported`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
