amoeba commented on code in PR #4186:
URL: https://github.com/apache/arrow-adbc/pull/4186#discussion_r3046546604
##########
docs/source/development/releasing.rst:
##########
@@ -440,16 +440,27 @@ Be sure to go through on the following checklist:
A conda-forge or feedstock maintainer can review and merge.
-.. dropdown:: Update Homebrew formulae
+.. dropdown:: Check Homebrew formulae
:class-title: sd-fs-5
:class-container: sd-shadow-md
- File separate PRs to update each formula for the new release:
+ Homebrew automatically updates formulae every 3 hours so the release
manager can just check that this happens.
+
+ Visit https://github.com/Homebrew/homebrew-core/pulls?q=is%3Apr+adbc and
look for separate PRs from BrewTestBot for each of these formulae:
- apache-arrow-adbc
- apache-arrow-adbc-glib
- See https://docs.brew.sh/Formula-Cookbook#updating-formulae.
+ If the formulae aren't automatically updated on schedule, run the following
to create PRs updating them:
+
+ .. code-block:: Bash
+
+ brew tap homebrew/core
+ cd $(brew --repository homebrew/core)
+ brew bump-formula-pr --version <VERSION> apache-arrow-adbc
+ brew bump-formula-pr --version <VERSION> apache-arrow-adbc-glib
Review Comment:
I haven't tested these fully but I think this would be the way to update the
formulae manually if we ever have to. It seems like `bump-formula-pr` can do
some basic text replacement when you use `--version` like this and I think we
want to update it this way instead of with `--tag`.
I did a partial test locally like this,
```
$ brew bump-formula-pr --dry-run --version 24 apache-arrow-adbc-glib
Warning: These open pull requests might be duplicates:
apache-arrow-adbc-glib 23.0.0 (new formula)
https://github.com/Homebrew/homebrew-core/pull/273401
Duplicate PRs must not be opened.
Manually open these PRs if you are sure that they are not duplicates (and
tell us that in the PR).
==> Downloading
https://www.apache.org/dyn/closer.lua?path=arrow/apache-arrow-adbc-24/apache-arrow-adbc-24.tar.gz
==> Downloading from
https://dlcdn.apache.org/arrow/apache-arrow-adbc-24/apache-arrow-adbc-24.tar.gz
curl: (56) The requested URL returned error: 404
Trying a mirror...
==> Downloading
https://downloads.apache.org/arrow/apache-arrow-adbc-24/apache-arrow-adbc-24.tar.gz
curl: (22) The requested URL returned error: 404
Error: Failed to download resource "apache-arrow-adbc-glib"
Download failed:
https://downloads.apache.org/arrow/apache-arrow-adbc-24/apache-arrow-adbc-24.tar.gz
curl: (22) The requested URL returned error: 404
```
and you can see it guessed `apache-arrow-adbc-24`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
