zanmato1984 commented on PR #49682: URL: https://github.com/apache/arrow/pull/49682#issuecomment-4201150524
Thanks for the fix. Switching from `std::multimap::extract(key)` to `lower_bound(key)` + `erase(iterator)` is the right change here. It makes duplicate-field selection deterministic (first matching field) and matches the expected behavior covered by the existing `StructToStructSubset` duplicate-name tests. LGTM. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
