alinaliBQ commented on PR #49603:
URL: https://github.com/apache/arrow/pull/49603#issuecomment-4201470708

   > I am unsure this is ready yet, sorry it took me a couple days for review, 
it was Easter and had some family around.  My main concern is around, the tag 
hasn't been updated to match the one on the packaging linux jobs, currently any 
tag will trigger the job and we only want to do it for RC's. 
   
   No worries @raulcd, hope you had a good Easter. 
   `odbc-msvc-upload-dll` is the job that is only triggered by `RC` tags. It 
does a `if` check to make sure the tag contains `-rc`:
   ```
        ${{ 
           startsWith(github.ref_name, 'apache-arrow-') && 
           contains(github.ref_name, '-rc') && 
           !inputs.odbc_release_step 
         }}
   ```
   Since having a `tags:` section will impact all jobs in the `cpp_extra.yml` 
file, I used the `if` statement approach to the job `odbc-msvc-upload-dll`. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to