etseidl commented on code in PR #9673:
URL: https://github.com/apache/arrow-rs/pull/9673#discussion_r3059998068


##########
parquet/src/util/push_buffers.rs:
##########
@@ -156,7 +156,6 @@ impl PushBuffers {
     }
 
     /// Clear all buffered ranges and their corresponding data
-    #[cfg(feature = "arrow")]

Review Comment:
   Well, the feature gate is necessary without the changes in this PR 😉.
   
   IIRC the CI will do builds with various sets of features enabled. The actual 
unit tests are then run with default features and all features.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to