sdf-jkl commented on code in PR #9676:
URL: https://github.com/apache/arrow-rs/pull/9676#discussion_r3064458603
##########
parquet-variant-compute/src/variant_get.rs:
##########
@@ -43,14 +43,15 @@ pub(crate) enum ShreddedPathStep<'a> {
}
/// Given a shredded variant field -- a `(value?, typed_value?)` pair -- try
to take one path step
-/// deeper. For a `VariantPathElement::Field`, the step fails if there is no
`typed_value` at this
-/// level, or if `typed_value` is not a struct, or if the requested field name
does not exist.
+/// deeper. For a `VariantPathElement::Field`, if there is no `typed_value` at
this level, if
+/// `typed_value` is not a struct, or if the requested field name does not
exist, traversal returns
+/// a missing-path step (`Missing` or `NotShredded` depending on whether
`value` exists).
///
/// TODO: Support `VariantPathElement::Index`? It wouldn't be easy, and maybe
not even possible.
pub(crate) fn follow_shredded_path_element<'a>(
shredding_state: &BorrowedShreddingState<'a>,
path_element: &VariantPathElement<'_>,
- cast_options: &CastOptions,
+ _cast_options: &CastOptions,
Review Comment:
If this PR goes first, the next `variant_get` PR will return it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
