sdf-jkl commented on code in PR #9685:
URL: https://github.com/apache/arrow-rs/pull/9685#discussion_r3065678953
##########
parquet-variant-compute/src/variant_array_builder.rs:
##########
@@ -156,6 +156,26 @@ impl VariantArrayBuilder {
self.value_offsets.push(self.value_builder.offset());
}
+ /// Appends `count` null rows to the builder.
+ pub fn append_nulls(&mut self, count: usize) {
+ if count == 0 {
+ return;
+ }
+ if count == 1 {
Review Comment:
Valid point on uniformity with other builders, thanks! I followed the
`MapBuilder` more with `.extend`.
Fixed here
https://github.com/apache/arrow-rs/pull/9685/commits/55d3d3889654974683e5b1b4fa096bd511e742ca
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
