serramatutu opened a new pull request, #758:
URL: https://github.com/apache/arrow-go/pull/758

   ### Rationale for this change
   
   For more context: 
https://github.com/apache/arrow-go/pull/558/changes#r2758798540
   
   ### What changes are included in this PR?
   
   This commit introduces an implementation of `UnsafeAppendBoolToBitmap()`
   to `dictionaryBuilder` and `RunEndEncodedBuilder`. The current
   implementation pulled from `arrow/array/builder.go` would leave the
   builders in invalid states that would panic when trying to finish a
   record batch.
   
   For `dictionaryBuilder`, we defer the implementation to the inner
   `indexBuilder`, which will in turn increase the logical length of the
   inner buffer and set the bit.
   
   For `RunEndEncodedBuilder` I decided to just panic after talking to
   @felipecrv since the semantics of what it should do are not clear.
   
   
   ### Are these changes tested?
   
   
   ### Are there any user-facing changes?
   
   No.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to