alamb commented on code in PR #9692:
URL: https://github.com/apache/arrow-rs/pull/9692#discussion_r3075209105
##########
arrow-buffer/src/buffer/null.rs:
##########
@@ -84,6 +84,20 @@ impl NullBuffer {
}
}
+ /// Computes the union of the nulls in multiple optional [`NullBuffer`]s
+ ///
+ /// See [`union`](Self::union)
+ pub fn union_many(nulls: &[Option<&NullBuffer>]) -> Option<NullBuffer> {
Review Comment:
This might be more generic if we had it take the iterator so it wouldn't
require a slice
```rust
pub fn union_many(nulls: impl IntoIterator<Item=Option<&NullBuffer>)) ->
Option<NullBuffer> {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
