jhorstmann commented on code in PR #9704:
URL: https://github.com/apache/arrow-rs/pull/9704#discussion_r3076123808


##########
NOTICE.txt:
##########
@@ -4,81 +4,17 @@ Copyright 2016-2026 The Apache Software Foundation
 This product includes software developed at
 The Apache Software Foundation (http://www.apache.org/).
 
-This product includes software from the SFrame project (BSD, 3-clause).
-* Copyright (C) 2015 Dato, Inc.
-* Copyright (c) 2009 Carnegie Mellon University.
+This product includes software from the chronoutil crate (MIT)
+ * Copyright (c) 2020-2022 Oliver Margetts
+ * https://github.com/olliemath/chronoutil
 
-This product includes software from the Feather project (Apache 2.0)
-https://github.com/wesm/feather
+This product includes software from the compact-thrift project (Apache 2.0)
+ * Copyright Jörn Horstmann
+ * https://github.com/jhorstmann/compact-thrift

Review Comment:
   My main contribution was probably the idea and prototype to use rust macros, 
with the goal to contribute that code. Then @etseidl did all the hard work of 
actually integrating that idea into the arrow-rs codebase.
   
   I would be fine to leave this out of the NOTICE file since there is no code 
that could be considered a direct copy from that repo. I'm happy with the 
shout-out I got in to blog post about faster parquet parsing :)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to