nathanb9 commented on code in PR #9697:
URL: https://github.com/apache/arrow-rs/pull/9697#discussion_r3075604567
##########
parquet/src/file/metadata/push_decoder.rs:
##########
@@ -361,6 +360,7 @@ impl ParquetMetaDataPushDecoder {
/// Try to decode the metadata from the pushed data, returning the
/// decoded metadata or an error if not enough data is available.
pub fn try_decode(&mut self) -> Result<DecodeResult<ParquetMetaData>> {
+ self.buffers.ensure_sorted();
Review Comment:
Don't need this because you later call the push buffers's `get_bytes` which
also ensures of the order. But since you've made it short circuit anyway maybe
its worth leaving for easier readability
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
