scovich commented on code in PR #9663:
URL: https://github.com/apache/arrow-rs/pull/9663#discussion_r3080640512
##########
parquet-variant-compute/src/shred_variant.rs:
##########
@@ -321,12 +328,19 @@ impl<'a> VariantToShreddedArrayVariantRowBuilder<'a> {
// If the variant is not an array, typed_value must be null.
// If the variant is an array, value must be null.
match variant {
- Variant::List(list) => {
+ Variant::List(ref list) => {
self.nulls.append_non_null();
- self.value_builder.append_null();
- self.typed_value_builder
- .append_value(&Variant::List(list))?;
- Ok(true)
+
+ // With `safe` cast option set to false, appending list of
wrong size to
+ // `typed_value_builder` of type `FixedSizeList` will result
in an error. In such a
+ // case, the provided list should be appended to the
`value_builder.
Review Comment:
I'm not sure the variant shredding
[spec](https://github.com/apache/parquet-format/blob/master/VariantShredding.md#arrays)
allows for shredding as a fixed size list, if the resulting layout differs
physically from a normal list?
> Arrays can be shredded by using a 3-level Parquet list for `typed_value.`
>
> If the value is not an array, `typed_value` must be null. If the value is
an array, `value` must be null.
It looks to me like any attempt to shred as fixed-sized list must either
succeed (because the size is correct) or hard-fail (because `value` as fallback
is not allowed).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
