itamarst commented on a change in pull request #9631:
URL: https://github.com/apache/arrow/pull/9631#discussion_r627483558



##########
File path: cpp/src/parquet/encryption/encryption.h
##########
@@ -70,6 +70,26 @@ class PARQUET_EXPORT StringKeyIdRetriever : public 
DecryptionKeyRetriever {
   std::map<std::string, std::string> key_map_;
 };
 
+// Function variant of DecryptionKeyRetriever, taking a state object.

Review comment:
       This isn't a performance critical path, so I think I will try the 
subclassing path for simplicity's sake.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to