lidavidm commented on code in PR #746:
URL: https://github.com/apache/arrow-go/pull/746#discussion_r3083172658
##########
parquet/pqarrow/file_writer.go:
##########
@@ -33,6 +33,48 @@ import (
"golang.org/x/xerrors"
)
+// normalizeFieldForParquet recursively normalizes an Arrow field so that its
+// type matches the Parquet column structure that fieldToNode would produce.
+// Specifically, list element field names are set to "element" because
+// ListOfWithName (used by fieldToNode) always names the Parquet element group
+// "element", regardless of the original Arrow element field name.
+func normalizeFieldForParquet(f arrow.Field) arrow.Field {
Review Comment:
Fair enough. Can we explicitly bail out so there's no chance of forgetting
to update this later on? (I think we might consider a generic traverser API,
this need comes up often enough, but apart from arrow-java this is something
lacking from other major Arrow implementations too AFAIK :sweat_smile:)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
