zeroshade commented on issue #4231: URL: https://github.com/apache/arrow-adbc/issues/4231#issuecomment-4255063525
While I can agree with the sentiment, I'm not particularly fond of this particular approach. We shouldn't re-use the `AdbcError` struct for the details like that and this isn't particularly generic and would require a user to have a separate one of these per-driver they utilize. The better solution (IMHO) is for this to be handled by the driver if necessary and should just require enough information at the initial connection state to be able to refresh (or vend) credentials. Such as passing a private JWT/PEM file, or OAuth2 secret/principal/etc. > /// The handler must not call any ADBC functions other than the > /// ConnectionSetOption functions and releasing the warning. The handler doesn't have the connection itself, so how would it call `ConnectionSetOption`? Additionally, most drivers only process credential options before establishing the connection and wouldn't re-process credentials upon calling `ConnectionSetOption`. Isn't it sufficient to just update the credentials and open a new connection in that scenario? (which is what the driver would have to do internally anyways). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
