HippoBaro commented on code in PR #9653:
URL: https://github.com/apache/arrow-rs/pull/9653#discussion_r3089882061
##########
parquet/src/file/metadata/mod.rs:
##########
@@ -929,6 +929,12 @@ impl LevelHistogram {
self.inner[level as usize] += 1;
}
}
+
+ /// Increments the count for a level value by `count`.
+ #[inline]
+ pub fn update_n(&mut self, level: i16, count: i64) {
Review Comment:
Agreed, `_n` isn’t great (I’ll probably rename the `put_n_*` symbols as
well). For now, I’ll go with `increment_by`. `update_n|update_count` can be
interpreted as replacing the count with a new value. The function increments
(as the doc already states), so this seems like the clearest option.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
