lidavidm commented on PR #49688:
URL: https://github.com/apache/arrow/pull/49688#issuecomment-4256851042
Incidentally the build log notes lots of warnings that may be good to tackle.
```
/Users/runner/work/arrow/arrow/cpp/src/arrow/flight/sql/odbc/tests/columns_test.cc:367:10:
warning: unused variable 'num_val' [-Wunused-variable]
367 | SQLLEN num_val = 0;
| ^~~~~~~
/Users/runner/work/arrow/arrow/cpp/src/arrow/flight/sql/odbc/tests/columns_test.cc:449:23:
warning: implicit conversion of NULL constant to 'const SQLSMALLINT' (aka
'const short') [-Wnull-conversion]
437 | CheckMockSQLColumns(stmt,
| ~~~~~~~~~~~~~~~~~~~
438 | std::wstring(L"main"), //
expected_catalog
439 | std::wstring(L"foreignTable"), //
expected_table
440 | std::wstring(L"id"), //
expected_column
441 | SQL_BIGINT, //
expected_data_type
442 | std::wstring(L"BIGINT"), //
expected_type_name
443 | 10, // expected_column_size (mock returns 10
instead of 19)
444 | 8, // expected_buffer_length
445 | 15, // expected_decimal_digits (mock returns
15 instead of 0)
446 | 10, // expected_num_prec_radix
447 | SQL_NULLABLE, // expected_nullable
448 | SQL_BIGINT, //
expected_sql_data_type
449 | NULL, //
expected_date_time_sub
| ^~~~
| 0
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
