tilinna commented on issue #703:
URL: https://github.com/apache/arrow-go/issues/703#issuecomment-4258336473
Seems that I've mixed the two file writers. Here's a recap of the issues:
1) arrow-go/v18/parquet/pqarrow/file_writer.go
Should mention here that it will call Close() on the underlying io.Writer if
it implements io.Closer.
```go
// Close flushes out the data and closes the file. It can be called multiple
times,
// subsequent calls after the first will have no effect.
func (fw *FileWriter) Close() error {
..
}
```
2) arrow-go/v18/parquet/file/file_writer.go
Should also mention here that it will call Close() on the underlying
io.Writer if it implements io.Closer.
Further, there's a bug in the Close that it will always return nil.
```go
// Close closes any open row group writer and writes the file footer.
Subsequent
// calls to close will have no effect.
func (fw *Writer) Close() (err error) {
if fw.open {
..
}
return nil
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
