alamb commented on code in PR #9658:
URL: https://github.com/apache/arrow-rs/pull/9658#discussion_r3092513621


##########
arrow-json/Cargo.toml:
##########
@@ -40,7 +40,9 @@ arrow-array = { workspace = true }
 arrow-buffer = { workspace = true }
 arrow-cast = { workspace = true }
 arrow-data = { workspace = true }
+arrow-ord = { workspace = true }

Review Comment:
   These are fairly non trivial crates (ord and select) so it is sad to see the 
dependencies being added here
   
   That being said, I think it is becoming clear that anything involving REE 
benefits from those two 
   
   Maybe we could split them up or osmething into new crates with the "core" 
parts (specifically partition and take) 🤔 
   
   `arrow-take` and `arrow-partition` maybe 🤔 
   
   I'll file a ticket to consider this



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to