abhishek593 commented on code in PR #49304:
URL: https://github.com/apache/arrow/pull/49304#discussion_r3103114564
##########
cpp/src/arrow/compute/kernels/vector_sort_test.cc:
##########
@@ -2362,6 +2341,24 @@ TEST_F(TestRank, Real) {
}
}
+TEST_F(TestRank, NaNsAndNulls) {
+ auto type = float64();
+ auto array = ArrayFromJSON(type, "[1.0, null, NaN, 2.0, NaN, null]");
+ SetInput(array);
+
+ // Sorted order (at_end): [1.0, 2.0, NaN, NaN, null, null]
+ // Ranks (min): [1, 5, 3, 2, 3, 5]
+ auto expected_at_end = ArrayFromJSON(uint64(), "[1, 5, 3, 2, 3, 5]");
+ AssertRank(SortOrder::Ascending, NullPlacement::AtEnd, RankOptions::Min,
+ expected_at_end);
+
+ // Sorted order (at_start): [null, null, NaN, NaN, 1.0, 2.0]
+ // Ranks (min): [5, 1, 3, 6, 3, 1]
+ auto expected_at_start = ArrayFromJSON(uint64(), "[5, 1, 3, 6, 3, 1]");
+ AssertRank(SortOrder::Ascending, NullPlacement::AtStart, RankOptions::Min,
+ expected_at_start);
Review Comment:
@zanmato1984 I have added tests for descending order as well. Sorry for the
delay.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
