Dandandan commented on code in PR #9758:
URL: https://github.com/apache/arrow-rs/pull/9758#discussion_r3104935189
##########
arrow-select/src/coalesce.rs:
##########
@@ -611,6 +718,19 @@ trait InProgressArray: std::fmt::Debug + Send + Sync {
/// Return an error if the source array is not set
fn copy_rows(&mut self, offset: usize, len: usize) -> Result<(),
ArrowError>;
+ /// Copy rows addressed by `indices` from the current source array.
+ fn copy_indices(&mut self, indices: &dyn Array) -> Result<(), ArrowError> {
+ downcast_integer_array!(indices => {
+ for index in indices.values() {
Review Comment:
This seems it would be slower than take? Would be better to avoid this for
the general case (e.g. not implemented ones)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
