pchintar opened a new pull request, #9763: URL: https://github.com/apache/arrow-rs/pull/9763
# Which issue does this PR close? - Closes #9762 . # Rationale for this change Currently, `flush()` is called unconditionally in `write_body_buffers` and `write_continuation` - both executed per batch. This forces per-batch syscalls, breaks write coalescing, and adds unnecessary overhead. These flushes are not required for correctness (IPC boundaries are length-prefixed, no durability guarantees). # What changes are included in this PR? - Remove `flush()` from `write_body_buffers` and `write_continuation` - Add `self.writer.flush()?` to `StreamWriter::finish()` (missing; `FileWriter::finish()` already has it) # Are these changes tested? Yes the changes were tested successfully by running: ```bash cargo test -p arrow-ipc cargo fmt --all cargo clippy --all-targets --all-features -- -D warnings ``` # Are there any user-facing changes? No, There are no changes made to any Public APIs -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
