haohuaijin commented on code in PR #9766:
URL: https://github.com/apache/arrow-rs/pull/9766#discussion_r3106459714
##########
parquet/benches/arrow_reader_row_filter.rs:
##########
@@ -180,17 +180,24 @@ fn create_record_batch(size: usize) -> RecordBatch {
RecordBatch::try_new(schema, arrays).unwrap()
}
+/// Total number of rows.
+const TOTAL_ROWS: usize = 500_000;
+
+/// Maximum rows per row group.
+const ROW_GROUP_SIZE: usize = 100_000;
+
/// Writes the RecordBatch to an in memory buffer, returning the buffer
fn write_parquet_file() -> Vec<u8> {
- let batch = create_record_batch(100_000);
- println!("Batch created with {} rows", 100_000);
+ let batch = create_record_batch(TOTAL_ROWS);
+ println!("Batch created with {TOTAL_ROWS} rows, row group size =
{ROW_GROUP_SIZE}");
Review Comment:
increase the row groups number to better show the performance improve for
this pr
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
