lidavidm commented on code in PR #49784:
URL: https://github.com/apache/arrow/pull/49784#discussion_r3107669091
##########
cpp/src/arrow/flight/sql/odbc/tests/odbc_test_suite.h:
##########
Review Comment:
Instead of globals, could we keep them as fields on the test fixture? Those
would still be accessible by tests
##########
cpp/src/arrow/flight/sql/odbc/tests/CMakeLists.txt:
##########
@@ -42,6 +42,11 @@ set(ARROW_FLIGHT_SQL_ODBC_TEST_SRCS
# GH-46889: move protobuf_test_util to a more common location
../../../../engine/substrait/protobuf_test_util.cc)
+# Resolve segmentation fault error on Windows platform due to Arrow Compute
Library Initialization
+if(WIN32)
+ list(APPEND ARROW_FLIGHT_SQL_ODBC_TEST_SRCS ../../../../compute/test_env.cc)
+endif()
Review Comment:
If this is needed, I'd rather we copy
`ASSERT_OK(arrow::compute::Initialize());` to our own googletest environment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
