kris-gaudel commented on code in PR #49512:
URL: https://github.com/apache/arrow/pull/49512#discussion_r3108691073
##########
cpp/src/arrow/util/hashing.h:
##########
@@ -534,13 +534,16 @@ class ScalarMemoTable : public MemoTable {
// Merge entries from `other_table` into `this->hash_table_`.
Status MergeTable(const ScalarMemoTable& other_table) {
const HashTableType& other_hashtable = other_table.hash_table_;
+ Status status = Status::OK();
- other_hashtable.VisitEntries([this](const HashTableEntry* other_entry) {
+ other_hashtable.VisitEntries([this, &status](const HashTableEntry*
other_entry) {
Review Comment:
I changed `VisitEntries` since the function looks quite manageable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]