Jimexist commented on pull request #275: URL: https://github.com/apache/arrow-datafusion/pull/275#issuecomment-833955352
> Thanks a lot for this PR. > > I agree that these tests are very useful; I disagree with the approach taken here. > > First, postgres tests are not specific to the python implementation and should be addressed at DataFusion; e.g. by calling `datafusion-cli`; the Python part of this repository corresponds to the Python bindings, and the tests should correspond solely to that part of the code base (i.e. FFI works, mapping of RecordBatches work, API works, etc). > > If we need to use Python to run tests against postgres (e.g. due to a client), then let's create a separate directory that has a Python script that calls `datafusion-cli` and postgres client. > > IMO this also makes testing more difficult because it requires building the Python bindings to run then; imo testing DataFusion against a postgres specification engine should not require building Python bindings. that's a fair point, let me close this and take another approach. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
