ashdnazg commented on code in PR #9772:
URL: https://github.com/apache/arrow-rs/pull/9772#discussion_r3118351058
##########
arrow-array/src/ffi_stream.rs:
##########
@@ -100,6 +100,7 @@ pub struct FFI_ArrowArrayStream {
}
unsafe impl Send for FFI_ArrowArrayStream {}
+unsafe impl Sync for FFI_ArrowArrayStream {}
Review Comment:
Fair question, I should've mentioned this.
Notice that `FFI_ArrowArray` is already `Sync`:
https://github.com/ashdnazg/arrow-rs/blob/aaf160f76e92b838b917d5e4be62de693258405f/arrow-data/src/ffi.rs#L77
IMO since these are FFI objects, they're kind of "anything goes", because
whatever language you give them to, can do whatever it wants with them, so
disallowing it inside Rust seems unhelpful. In addition, what little safe API
they have, seems to be thread-safe (no cells and the like).
This is not super important, I can leave it out if you prefer, but I think
it does make sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
