pchintar commented on PR #9776: URL: https://github.com/apache/arrow-rs/pull/9776#issuecomment-4289644225
Thanks for the response @alamb . I haven’t run dedicated benchmarks yet. This change targets a specific accumulation pattern (repeated delta dictionary updates), which may not be directly covered by existing benchmarks and so may require a custom setup. Due to system/hardware constraints I wasn’t able to put that together, but the change removes a quadratic copy pattern and replaces it with a linear one, so the expected improvement must follow from that. I’m happy to follow up with a microbenchmark if needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
