alamb commented on code in PR #9752:
URL: https://github.com/apache/arrow-rs/pull/9752#discussion_r3121509265
##########
parquet/src/arrow/arrow_writer/levels.rs:
##########
@@ -336,51 +336,81 @@ impl LevelInfoBuilder {
})
};
- let write_empty_slice = |child: &mut LevelInfoBuilder| {
- child.visit_leaves(|leaf| {
- let rep_levels = leaf.rep_levels.as_mut().unwrap();
- rep_levels.push(ctx.rep_level - 1);
- let def_levels = leaf.def_levels.as_mut().unwrap();
- def_levels.push(ctx.def_level - 1);
- })
+ let write_null_run = |child: &mut LevelInfoBuilder, count: usize| {
Review Comment:
It took me a little while to grok that the `empty` and `null` cases got
reversed here, but once I got over that it seems good to me
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
