etseidl commented on code in PR #9795:
URL: https://github.com/apache/arrow-rs/pull/9795#discussion_r3128110595
##########
parquet/src/file/metadata/mod.rs:
##########
@@ -919,15 +919,10 @@ impl LevelHistogram {
}
}
- /// Updates histogram values using provided repetition levels
- ///
- /// # Panics
- /// if any of the levels is greater than the length of the histogram (
- /// the argument supplied to [`Self::try_new`])
- pub fn update_from_levels(&mut self, levels: &[i16]) {
Review Comment:
I think removing this is technically a breaking API change. I doubt anyone
uses it outside the crate, though.
##########
parquet/src/encodings/levels.rs:
##########
@@ -46,31 +46,35 @@ impl LevelEncoder {
///
/// This does not require knowing the number of values
/// upfront, making it suitable for incremental encoding where levels are
fed in
- /// as they arrive via [`put`](Self::put).
+ /// as they arrive via [`put_with_observer`](Self::put_with_observer).
pub fn v2_streaming(max_level: i16) -> Self {
let bit_width = num_required_bits(max_level as u64);
LevelEncoder::RleV2(RleEncoder::new_from_buf(bit_width, Vec::new()))
}
- /// Put/encode levels vector into this level encoder.
- /// Returns number of encoded values that are less than or equal to length
of the
- /// input buffer.
+ /// Put/encode levels vector into this level encoder and calls
Review Comment:
```suggestion
/// Put/encode levels vector into this level encoder and call
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
