thisisnic commented on a change in pull request #10190:
URL: https://github.com/apache/arrow/pull/10190#discussion_r627994829
##########
File path: r/src/compute.cpp
##########
@@ -233,6 +233,33 @@ std::shared_ptr<arrow::compute::FunctionOptions>
make_compute_options(
max_replacements);
}
+ if (func_name == "split_pattern") {
+ using Options = arrow::compute::SplitPatternOptions;
+ int64_t max_splits = -1;
+ if (!Rf_isNull(options["max_splits"])) {
+ max_splits = cpp11::as_cpp<int64_t>(options["max_splits"]);
+ }
+ bool reverse = false;
+ if (!Rf_isNull(options["reverse"])) {
+ reverse = cpp11::as_cpp<bool>(options["reverse"]);
+ }
+ return
std::make_shared<Options>(cpp11::as_cpp<std::string>(options["pattern"]),
+ max_splits, reverse);
+ }
+
+ if (func_name == "utf8_split_whitespace" || func_name ==
"ascii_split_whitespace") {
Review comment:
Nice!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
