HippoBaro commented on code in PR #9795:
URL: https://github.com/apache/arrow-rs/pull/9795#discussion_r3139263615
##########
parquet/src/file/metadata/mod.rs:
##########
@@ -919,14 +919,21 @@ impl LevelHistogram {
}
}
+ /// Increments the count for a level value by `count`.
+ #[inline]
+ pub fn increment_by(&mut self, level: i16, count: i64) {
+ self.inner[level as usize] += count;
+ }
+
/// Updates histogram values using provided repetition levels
///
/// # Panics
/// if any of the levels is greater than the length of the histogram (
/// the argument supplied to [`Self::try_new`])
+ #[deprecated(since = "61.0.0", note = "Use `increment_by` instead")]
Review Comment:
Oh thanks! I actually used that version initially but then you made me doubt
myself in https://github.com/apache/arrow-rs/pull/9795#discussion_r3134346111
so I used that one instead :p
Let me fix that for you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
