zeroshade commented on code in PR #4263:
URL: https://github.com/apache/arrow-adbc/pull/4263#discussion_r3139518447
##########
java/driver/jni/src/main/cpp/jni_wrapper.cc:
##########
@@ -621,6 +723,19 @@
Java_org_apache_arrow_adbc_driver_jni_impl_NativeAdbc_statementSetOptionString(
}
}
+JNIEXPORT void JNICALL
+Java_org_apache_arrow_adbc_driver_jni_impl_NativeAdbc_connectionCancel(
+ JNIEnv* env, [[maybe_unused]] jclass self, jlong handle) {
+ struct AdbcError error = ADBC_ERROR_INIT;
+ auto* ptr = reinterpret_cast<struct
AdbcConnection*>(static_cast<uintptr_t>(handle));
+ struct ArrowSchema schema = {};
Review Comment:
same as elsewhere, drop since unused?
##########
java/driver/jni/src/main/cpp/jni_wrapper.cc:
##########
@@ -353,6 +373,88 @@ jobject MakeNativeSchemaResult(JNIEnv* env, struct
ArrowSchema* schema) {
static_cast<jlong>(reinterpret_cast<uintptr_t>(schema)));
}
+JNIEXPORT void JNICALL
+Java_org_apache_arrow_adbc_driver_jni_impl_NativeAdbc_statementCancel(
+ JNIEnv* env, [[maybe_unused]] jclass self, jlong handle) {
+ struct AdbcError error = ADBC_ERROR_INIT;
+ auto* ptr = reinterpret_cast<struct
AdbcStatement*>(static_cast<uintptr_t>(handle));
+ struct ArrowSchema schema = {};
Review Comment:
same as elsewhere, drop this since it's unused?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
