alamb commented on code in PR #9806:
URL: https://github.com/apache/arrow-rs/pull/9806#discussion_r3140661792


##########
arrow-ipc/src/reader.rs:
##########


Review Comment:
   Good catch -- this `_` is somewhat dangerous here as if/when new enums are 
added this branch may not be correctly caught. I suspect this is what happened 
when ListView was added 
   
   Perhaps you can make a follow on PR that removes the default branch entirely 
(and explicitly hard codes the remaining variants in the match arm) 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to