pchintar commented on PR #9778: URL: https://github.com/apache/arrow-rs/pull/9778#issuecomment-4317014806
Yes @alamb , so for other types (e.g. `UInt64Array`), if the underlying buffer is not aligned, the extra copy would already happen today via `ArrayDataBuilder::align_buffers(...)`, so that behavior doesn’t change with this PR. The difference here is that `Union` bypasses that path and directly constructs `ScalarBuffer<T>`, so the alignment repair needs to be made explicit in that one place. So effectively: * for most types → alignment/copy is already handled later (unchanged) * for `Union` → we make that same alignment requirement explicit at the conversion point -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
