alamb opened a new pull request, #9817: URL: https://github.com/apache/arrow-rs/pull/9817
# Which issue does this PR close? - None. # Rationale for this change Rows used unchecked usize arithmetic when validating a requested row index. In optimized builds, very large indexes could wrap the bounds check before reaching the unchecked row access path. # What changes are included in this PR? This adds checked arithmetic for row index validation and reuses it for both Rows::row and Rows::row_len. # Are these changes tested? Yes. This adds regression coverage for overflowing row indexes. # Are there any user-facing changes? Invalid row indexes that overflow during bounds validation now panic consistently. There are no API changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
