HippoBaro commented on code in PR #9804:
URL: https://github.com/apache/arrow-rs/pull/9804#discussion_r3142794071
##########
parquet/src/arrow/push_decoder/remaining.rs:
##########
@@ -83,40 +238,47 @@ impl RemainingRowGroups {
) -> Result<DecodeResult<ParquetRecordBatchReader>, ParquetError> {
loop {
// Are we ready yet to start reading?
- let result: DecodeResult<ParquetRecordBatchReader> =
- self.row_group_reader_builder.try_build()?;
- match result {
- DecodeResult::Finished => {
+ match self.row_group_reader_builder.try_build()? {
+ RowGroupBuildResult::Idle => {
Review Comment:
This is an intermediary step between `Finished` and the processing of the
next row group. `Idle` is appropriate is that narrow sense. And `Skipped` would
not be, because we are not skipping anything here.
Your remark makes me think this has to go anyways because it's confusing.:
I'll rework the code to just move from `Finished` to the next state directly
instead!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
